Repository navigation
Rename and update Github.xml - #12663
Conversation
|
|
|
Could be something to do with |
|
@Bisaloo Are we talking about the Chromium HSTS preload list or the Mozilla HSTS preload list? Either way, in both cases the @bardiharborow Did you figure it out? |
|
@Hainish |
|
see #12145 (comment). fixed by #12748 |
|
I tried to secure the <securecookie host="^github\.com$" name=".+" />
<securecookie host="^\.github\.com$" name=".+" />But this only works when If there's a way to enable the secure flag for all cookies on |
|
@christianheinrichs The cookies should not need securing. HSTS guarantees that |
|
@wesdawg that 307 redirect is the preloading. If you look more closely, it will say The only change that's valid in this PR anymore is adding |
|
|
||
| Secure connection failed: | ||
| - ssh.github.com | ||
| --> |
There was a problem hiding this comment.
Since we already have github.com proloaded, I think it's fine to remove these. Maybe you could just leave a comment to state that it's HSTS preloaded and thus doesn't need to be in the ruleset.
There was a problem hiding this comment.
Actually you don't need to mention the subdomains at all, as includeSubDomains is one of the requirements to get preloaded
There was a problem hiding this comment.
The newest commit should have fixed that.

Noticed that not all cookies were being secured, also added some subdomains.