Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Rename and update Github.xml - #12663

Merged
gloomy-ghost merged 6 commits into
EFForg:masterfrom
christianheinrichs:update-github
Oct 15, 2017
Merged

gloomy-ghost merged 6 commits into
EFForg:masterfrom
christianheinrichs:update-github

Conversation

@christianheinrichs

Copy link
Copy Markdown
Contributor

Noticed that not all cookies were being secured, also added some subdomains.

@Bisaloo

Bisaloo commented Sep 21, 2017

Copy link
Copy Markdown
Collaborator

github.com is preloaded. Not sure why this passes the tests.

@bardiharborow

Copy link
Copy Markdown
Contributor

Could be something to do with www not serving HSTS, but I need to confirm.

@christianheinrichs

Copy link
Copy Markdown
Contributor Author

@Bisaloo Are we talking about the Chromium HSTS preload list or the Mozilla HSTS preload list?

Either way, in both cases the github.com entry seems to be present and I might need to remove it from this ruleset.

@bardiharborow Did you figure it out?

@gloomy-ghost

Copy link
Copy Markdown
Collaborator

@Hainish github.com is present in esr52, any ideas that the test passed?

@bardiharborow

Copy link
Copy Markdown
Contributor

@cschanaj

Copy link
Copy Markdown
Collaborator

see #12145 (comment). fixed by #12748

@christianheinrichs

Copy link
Copy Markdown
Contributor Author

I tried to secure the github.com cookies by adding:

<securecookie host="^github\.com$" name=".+" />
<securecookie host="^\.github\.com$" name=".+" />

But this only works when github.com is included via target XML tag.

If there's a way to enable the secure flag for all cookies on github.com without having it included as target, please let me know.

@bardiharborow

Copy link
Copy Markdown
Contributor

@christianheinrichs The cookies should not need securing. HSTS guarantees that *.github.com will never be accessed over an unsecured connection – essentially a permanent <securecookie host=".+" name=".+" /> for the domain.

@wesinator

wesinator commented Oct 14, 2017 •

Copy link
Copy Markdown
Contributor

github.com is not preloading for me in Chrome (latest stable on Linux)
github_hsts
www is the same.

Am I missing something, or is there a really bad bug in Chrome ?

@bardiharborow

bardiharborow commented Oct 14, 2017 •

Copy link
Copy Markdown
Contributor

@wesdawg that 307 redirect is the preloading. If you look more closely, it will say 307 Internal Redirect, indicating that it's internally generated by Chrome.

The only change that's valid in this PR anymore is adding <securecookie host=".+" name=".+" />. The comment changes should be removed as github.com isn't covered by this ruleset.


Secure connection failed:
- ssh.github.com
-->

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we already have github.com proloaded, I think it's fine to remove these. Maybe you could just leave a comment to state that it's HSTS preloaded and thus doesn't need to be in the ruleset.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually you don't need to mention the subdomains at all, as includeSubDomains is one of the requirements to get preloaded

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The newest commit should have fixed that.

@gloomy-ghost
gloomy-ghost merged commit 07f3eca into EFForg:master Oct 15, 2017
@christianheinrichs
christianheinrichs deleted the update-github branch October 15, 2017 08:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants